[Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

Eric Engestrom eric.engestrom at imgtec.com
Wed May 25 16:51:46 UTC 2016

On Wed, May 25, 2016 at 09:33:30AM -0700, Kristian Høgsberg wrote:
> From: Kristian Høgsberg Kristensen <krh at bitplanet.net>
> The nested declaration of 'height' shadows a parameter and uses
> uninitialized memory. Fix by renaming to 'plane_height' which also makes
> the code clearer.
> This would typically break the bo size computation, but we don't use
> that except when mmaping, and we don't mmap YUV buffers much.
> Signed-off-by: Kristian Høgsberg Kristensen <krh at bitplanet.net>
> ---

Why does that even compile…

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

More information about the mesa-dev mailing list