[Mesa-dev] [PATCH] nir: Use double-precision pow() when bit_size is 64, powf() otherwise

Iago Toral itoral at igalia.com
Thu May 26 14:33:52 UTC 2016

On Thu, 2016-05-26 at 15:13 +0100, Emil Velikov wrote:
> On 19 May 2016 at 10:00, Iago Toral <itoral at igalia.com> wrote:
> > I have just noticed that this was never pushed, right? I noticed this
> > while working on providing double-precision implementation for the other
> > functions discussed in the thread.
> >
> You are correct Iago. Gents, can anyone get some light on the status
> of this patch.
> Has it been superseded by another, is there some work outstanding on this one ?

Just to clarify the situation:

This particular patch fixes something that is wrong in master as of now
so I think it makes sense to push it. I don't think we have any bugs
related to this because GLSL only has a 32-bit pow and as it is now we
would simply use pow instead of powf for that, which is not what we want
but should be safe, so even if we don't push this I don't think we have
a problem.

Then we need to decide if we want to keep 64-bit implementations of pow
and other functions that don't really need 64-bit support in GLSL or
not. But this is not urgent because we are talking about versions of
functions that are not exposed by GLSL for now. If we want to do it,
then we can review and push [1] which adds support for a couple more and
if we don't then we have to remove the support for pow and sin/cos that
is in master right now.

[1] https://lists.freedesktop.org/archives/mesa-dev/2016-May/117521.html


More information about the mesa-dev mailing list