[Mesa-dev] [PATCH] gallium: detect avx512 cpu features

[Kyriazis, George]

All good, but I would suggest matching the already existing editing style (ie correct tabulation, and zero-padding of cpuid() args.

Reviewed-By: George Kyriazis <george.kyriazis at intel.com>


> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Tim Rowley
> Sent: Wednesday, May 25, 2016 7:11 PM
> To: mesa-dev at lists.freedesktop.org
> Subject: [Mesa-dev] [PATCH] gallium: detect avx512 cpu features
> 
> ---
>  src/gallium/auxiliary/util/u_cpu_detect.c | 17 +++++++++++++++++
>  src/gallium/auxiliary/util/u_cpu_detect.h | 10 ++++++++++
>  2 files changed, 27 insertions(+)
> 
> diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c
> b/src/gallium/auxiliary/util/u_cpu_detect.c
> index aa3c30a..0d4a7c4 100644
> --- a/src/gallium/auxiliary/util/u_cpu_detect.c
> +++ b/src/gallium/auxiliary/util/u_cpu_detect.c
> @@ -387,6 +387,23 @@ util_cpu_detect(void)
>           util_cpu_caps.has_avx2 = (regs7[1] >> 5) & 1;
>        }
> 
> +      // check for avx512
> +      if (((regs2[2] >> 27) & 1) && // OSXSAVE
> +          (xgetbv() & (0x7 << 5)) && // OPMASK: upper-256 enabled by OS
> +          (xgetbv() & (0x3 << 1))) { // XMM/YMM enabled by OS
> +         uint32_t regs3[4];
> +         cpuid(0x7, regs3);
> +         util_cpu_caps.has_avx512f    = (regs3[1] >> 16) & 1;
> +         util_cpu_caps.has_avx512dq   = (regs3[1] >> 17) & 1;
> +         util_cpu_caps.has_avx512ifma = (regs3[1] >> 21) & 1;
> +         util_cpu_caps.has_avx512pf   = (regs3[1] >> 26) & 1;
> +         util_cpu_caps.has_avx512er   = (regs3[1] >> 27) & 1;
> +         util_cpu_caps.has_avx512cd   = (regs3[1] >> 28) & 1;
> +         util_cpu_caps.has_avx512bw   = (regs3[1] >> 30) & 1;
> +         util_cpu_caps.has_avx512vl   = (regs3[1] >> 31) & 1;
> +         util_cpu_caps.has_avx512vbmi = (regs3[2] >>  1) & 1;
> +      }
> +
>        if (regs[1] == 0x756e6547 && regs[2] == 0x6c65746e && regs[3] ==
> 0x49656e69) {
>           /* GenuineIntel */
>           util_cpu_caps.has_intel = 1;
> diff --git a/src/gallium/auxiliary/util/u_cpu_detect.h
> b/src/gallium/auxiliary/util/u_cpu_detect.h
> index 5ccfc93..b612a2c 100644
> --- a/src/gallium/auxiliary/util/u_cpu_detect.h
> +++ b/src/gallium/auxiliary/util/u_cpu_detect.h
> @@ -71,6 +71,16 @@ struct util_cpu_caps {
>     unsigned has_xop:1;
>     unsigned has_altivec:1;
>     unsigned has_daz:1;
> +
> +   unsigned has_avx512f:1;
> +   unsigned has_avx512dq:1;
> +   unsigned has_avx512ifma:1;
> +   unsigned has_avx512pf:1;
> +   unsigned has_avx512er:1;
> +   unsigned has_avx512cd:1;
> +   unsigned has_avx512bw:1;
> +   unsigned has_avx512vl:1;
> +   unsigned has_avx512vbmi:1;
>  };
> 
>  extern struct util_cpu_caps
> --
> 1.8.3.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev