[Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

[Ilia Mirkin]

On Thu, May 26, 2016 at 6:26 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 05/26/2016 03:03 PM, Ilia Mirkin wrote:
>> This will cause st/mesa to break, no? Right now validate_io iterates
>> over the shader ir, which st/mesa frees after linking.
>
> Only as much as it is already broken. :) Any desktop OpenGL application
> using GLSL ES shaders would already have that problem.  I suspect there
> are more of those than there are applications using debug contexts.  I

Doesn't glretrace create a debug context? Maybe I'm just imagining
things. One would have to do SSO in ES to observe the breaks right
now, which I think is pretty rare.

> believe this should all be cleared up after patch 6 in this series which
> deletes the old validate_io function.

Yeah... I'm just hoping this can get ordered after that patch. Or at
least be in the same series.

  -ilia