[Mesa-dev] [PATCH 14/18] mesa_glinterop: remove mesa_glinterop typedefs

Emil Velikov emil.l.velikov at gmail.com
Fri May 27 16:12:56 UTC 2016


On 27 May 2016 at 16:49, Marek Olšák <maraeo at gmail.com> wrote:
> On Fri, May 27, 2016 at 5:20 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 27 May 2016 at 16:03, Marek Olšák <maraeo at gmail.com> wrote:
>>> You don't need to keep the underscore at the beginning of the type
>>> names anymore.
>>>
>> If I drop that one things will clash with the typedef in
>> dri_interface.h. And obviously we don't want to include
>> mesa_glinterop.h from dri_interface.h as that will require us to
>> install the header (not to mention the implicit include in hundreds of
>> more compilation/build units).
>>
>> Perhaps there's something subtle that I'm missing ?
>
> dri_interface.h can be changed from:
>
> typedef struct _mesa_glinterop_device_info mesa_glinterop_device_info;
> typedef struct _mesa_glinterop_export_in mesa_glinterop_export_in;
> typedef struct _mesa_glinterop_export_out mesa_glinterop_export_out;
>
> to:
>
> struct mesa_glinterop_device_info;
> struct mesa_glinterop_export_in;
> struct mesa_glinterop_export_out;
>
Sure we can drop the typedef all together. Will send out v2 in a few hours.

Thanks
Emil


More information about the mesa-dev mailing list