[Mesa-dev] [PATCH 13/18] GROSS HACK: anv: add dummy MESA_GIT_SHA1 define

Jason Ekstrand jason at jlekstrand.net
Fri May 27 16:38:16 UTC 2016


On Fri, May 27, 2016 at 7:35 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> From: Emil Velikov <emil.velikov at collabora.com>
>
> Otherwise we'll error out if build from a release tarball.
>
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Cc: Kristian Høgsberg Kristensen <krh at bitplanet.net>
> ---
> This patch isn't going to fly obviously but is just enough to get things
> building ;-)
>

You're right.  It won't. :-)

I think what we need is to ship something that provides MESA_GIT_SHA1 in
the tarball.  The purpose of this is to ensure that any shader caches get
100% invalidated if the mesa version changes at all.  When Timothy lands
his shader cache stuff, we'll need this in the GL driver as well so we
might as well find a solution now.

All of the other (not this one) anv/isl patches in the series are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> Any input on proper fix is highly appreciated.
> ---
>  src/intel/vulkan/anv_device.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index eb40e2d..98eda2b 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -416,6 +416,9 @@ void
>  anv_device_get_cache_uuid(void *uuid)
>  {
>     memset(uuid, 0, VK_UUID_SIZE);
> +#ifndef MESA_GIT_SHA1
> +#define MESA_GIT_SHA1 "git-unknown"
> +#endif
>     snprintf(uuid, VK_UUID_SIZE, "anv-%s", MESA_GIT_SHA1 + 4);
>  }
>
> --
> 2.8.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160527/24c69dff/attachment.html>


More information about the mesa-dev mailing list