[Mesa-dev] [PATCH] mesa: Enable LTO compilation

[Emil Velikov]

Hi there,
On 30 May 2016 at 18:28, ⚛ <0xe2.0x9a.0x9b at gmail.com> wrote:
> This patch enables compilation with -flto.
>
> The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for glxgears.
> Performance changes in OpenGL games haven't been measured yet, my feeling is
> that they are negligible.
>
Please try to send patches via git send-email for the future.

While not a hard requirement, it would be nice if you setup your email
client/git to show your name/nickname.
It's always better to address someone directly, as opposed to "hey you".

About the patch itself:
 - Please add a summary message for the change. Peter's has a nice
article on the topic [1].
 - We normally try to include performance metrics in the commit
message. It makes it easier to justify said change.
 - Have you tried debugging the resulting binary ? As Matt mentioned
there used to be issues with LTO, so if those are still unresolved we
want to _avoid_ forcing that for everyone.
 - Are you use the mapi hunk is needed ? last time I've tried (some
months ago, copying the tweaks from the Clearlinux spec file [2])
things built without issues.

Thanks
Emil

[1] http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html
[2] https://download.clearlinux.org/releases/8470/clear/source/SRPMS/