[Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

Emil Velikov emil.l.velikov at gmail.com
Mon May 30 20:21:33 UTC 2016

On 30 May 2016 at 21:11, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, May 30, 2016 at 5:46 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> As we'll need the file in the release tarball, rework the rule so that
>> the file is regenerated _only_ if we're in a git repository.
>> With this in place we can build vulkan (anv) from a release tarball.
>> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
>> Cc: Kristian Høgsberg Kristensen <krh at bitplanet.net>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>> Not 100% sure if we want the file in any of the clean targets. I'm
>> leaning towards "no", yet I'm open to input.
> That would prevent rebuilds after 'make clean' when built from a
> tarball, wouldn't it?
Reading my comment ... it sounds a bit odd/misleading. It should have said:
 "I'm leaning that we don't want to cleanup the file. Not 100% sure so
I'm open to suggestions."

And yes. If we clean the file (with any target) then there'll be no
way to regenerate it when building from tarball. And thus we won't be
able to build Vulkan.


More information about the mesa-dev mailing list