[Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

[Emil Velikov]

On 30 May 2016 at 22:02, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On May 30, 2016 1:56 PM, "Grazvydas Ignotas" <notasas at gmail.com> wrote:
>>
>> On Mon, May 30, 2016 at 3:46 PM, Emil Velikov <emil.l.velikov at gmail.com>
>> wrote:
>> > From: Emil Velikov <emil.velikov at collabora.com>
>> >
>> > As we'll need the file in the release tarball, rework the rule so that
>> > the file is regenerated _only_ if we're in a git repository.
>> >
>> > With this in place we can build vulkan (anv) from a release tarball.
>>
>> After this commit the OpenGL version strings no longer update as I
>> move around my git commits and rebuild.
It did when I tried it here. Do you have any specific steps ?

>> There was also a reason for
>> the .tmp file and cmp, so it doesn't rebuild everything #including
>> git_sha1.h every time.
>
There's a single file that includes the header so "everything" sounds
a bit strange ;-)

> I was wondering about that...
>
> I know that we've had some trouble with git_sha1.h getting regenerated in
> the past. Maybe this was an oversimplification. :-(
>
Since we want to generate a file with actual contents every time
possible (we could have done a dummy one before) it didn't make sense
to keep it. If people want it back we could do that.

-Emil