[Mesa-dev] [android-x86-devel] [PATCH 1/3] android: define MESA_EGL_NO_X11_HEADERS

[Emil Velikov]

Hi Mauro,

On 30 May 2016 at 23:20, Mauro Rossi <issor.oruam at gmail.com> wrote:
> In order to avoid building errors due to missing X11 headers
>
> Cc: <mesa-stable at lists.freedesktop.org>
> ---
>  Android.common.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Android.common.mk b/Android.common.mk
> index cdba85f..5df9b7e 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -56,6 +56,7 @@ LOCAL_CFLAGS += \
>         -DHAVE___BUILTIN_UNREACHABLE \
>         -DHAVE_PTHREAD=1 \
>         -DHAVE_DLOPEN \
> +       -DMESA_EGL_NO_X11_HEADERS \
Are you sure we need this with current master ?

The only place that checks for this is in include/EGL/eglplatform.h
and that one is done after #elif defined(__ANDROID__) ||
defined(ANDROID). Pretty sure that Android defines at least one of
those two, thus we should never reach the MESA_EGL_NO_X11_HEADERS
part.

Thanks
Emil