[Mesa-dev] [PATCH 23/25] i965/fs: Allow scalar source regions on SNB math instructions.

[Matt Turner]

On Mon, May 30, 2016 at 10:34 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Fri, May 27, 2016 at 7:06 PM, Francisco Jerez <currojerez at riseup.net> wrote:
>> I haven't found any evidence that this isn't supported by the
>> hardware, in fact according to the SNB hardware spec:
>>
>>  "The supported regioning modes for math instructions are align16,
>>   align1 with the following restrictions:
>>    - Scalar source is supported.
>>   [...]
>>    - Source and destination offset must be the same, except the case of
>>      scalar source."
>
> Strange. I added code to copy propagate to handle this, fixing some
> regressions in
>
> commit 7f5a8ac155283e78df2da5b172a65361a80d38b6
> Author: Matt Turner <mattst88 at gmail.com>
> Date:   Sat Apr 25 01:50:04 2015 -0700
>
>     i965/fs: Disallow constant propagation into POW on Gen 6.
>
>     Fixes assertion failures in three piglit tests on Gen 6 since commit
>     0087cf23e.
>
> I'd like to run piglit before and after that commit and see what
> changed on Sandybridge. I'll push it to Jenkins.

Well, I can't reproduce any any failures I evidently saw.

Reviewed-by: Matt Turner <mattst88 at gmail.com>