[Mesa-dev] [PATCH 2/2] automake: bring back the .PHONY git_sha1.h.tmp rule

Grazvydas Ignotas notasas at gmail.com
Tue May 31 20:36:24 UTC 2016

On Tue, May 31, 2016 at 4:55 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> With earlier commit 3689ef32afd ("automake: rework the git_sha1.h rule,
> include in tarball") we/I erroneously removed the PHONY rule and the
> temporary file.
> The former is used to ensure that the header is regenerated when on each
> make invocation, while the latter helps us avoid the unneeded rebuild(s)
> when the SHA1 hasn't changed.
> Cc: Grazvydas Ignotas <notasas at gmail.com>
> Reported-by: Grazvydas Ignotas <notasas at gmail.com>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> And the brown paper bag for "keep one change per commit" goes to yours
> truly... Grazvydas can you give it a test on your end ?

Was about to write "it doesn't work" but it turns out I had
./src/mesa/main/git_sha1.h lying around from an earlier build. After
deleting that one it all works.

Tested-by: Grazvydas Ignotas <notasas at gmail.com>


More information about the mesa-dev mailing list