[Mesa-dev] [PATCH 1/3] dri2: Serialize with all X rendering on glXWaitX()

[Adam Jackson]

On Sat, 2016-10-22 at 11:00 +0100, Chris Wilson wrote:
> Xorg may implement fine grained per-drawable serialisation. If the
> client is reading from shared pixmap sources, flushing rendering to the
> current drawable is not enough (even if the current code did that, it
> does not). Instead, following a glXWaitX() ensure that all X rendering to
> shared buffers associated with the glXContext is flushed by doing a
> DRI2GetBuffers() roundtrip prior to GL rendering.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=52930
> References: https://bugs.freedesktop.org/show_bug.cgi?id=90264
> References: https://bugs.freedesktop.org/show_bug.cgi?id=97914
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  include/GL/internal/dri_interface.h         | 12 ++++++++-
>  src/glx/dri2_glx.c                          | 16 ++++++++++--
>  src/mesa/drivers/dri/common/dri_util.c      |  6 +++++
>  src/mesa/drivers/dri/common/dri_util.h      |  4 +++
>  src/mesa/drivers/dri/i965/brw_context.c     | 38 ++++++++---------------------
>  src/mesa/drivers/dri/i965/brw_context.h     | 23 +++++++++++++++--
>  src/mesa/drivers/dri/i965/intel_screen.c    |  5 ++--
>  src/mesa/drivers/dri/i965/intel_tex_image.c |  5 ++--
>  8 files changed, 71 insertions(+), 38 deletions(-)

Hm, adding myself to REVIEWERS for src/glx/ doesn't seem to have done
much. Also I'd still really like to see a server-side call chain for
WaitX/WaitGL, but.

With the fd leak from 2/3 fixed, this series is:

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax