[Mesa-dev] [PATCH v4] clover: Pass unquoted compiler arguments to Clang

[Vedran Miletić]

On 10/30/2016 08:16 PM, Francisco Jerez wrote:
> Vedran Miletić <vedran at miletic.net> writes:
> 
>> OpenCL apps can quote arguments they pass to the OpenCL compiler, most
>> commonly include paths containing spaces.
>>
>> If the Clang OpenCL compiler was called via a shell, the shell would
>> split the arguments with respect to to quotes and then remove quotes
>> before passing the arguments to the compiler. Since we call Clang as a
>> library, we have to split the argument with respect to quotes and then
>> remove quotes before passing the arguments.
>>
>> v2: move to tokenize(), remove throwing of CL_INVALID_COMPILER_OPTIONS
>>
>> v3: simplify parsing logic, use more C++11
>>
>> v4: restore error throwing, clarify a comment
>>
>> Signed-off-by: Vedran Miletić <vedran at miletic.net>
> 
> R-b and pushed.  Thanks!
> 

Thank you!

Vedran

-- 
Vedran Miletić
vedran.miletic.net