[Mesa-dev] [PATCH 1/3] st/mesa/r200/i915/i965: use rzalloc() to create gl_program

[Timothy Arceri]

On Wed, 2016-11-02 at 16:27 -0700, Eric Anholt wrote:
> Timothy Arceri <timothy.arceri at collabora.com> writes:
> 
> > 
> > This will allow us to move some fields from gl_linked_shader to
> > gl_program, which will allow us to do some clean-ups like storing
> > gl_program directly in the CurrentProgram array in
> > gl_pipeline_object
> > enabling some small validation optimisations at draw time.
> > 
> > Also it is error prone to depend on the gl_linked_shader for
> > programs in current use because a failed linking attempt will free
> > infomation about the current program. In i965 we could be trying
> > to recompile a shader variant but may have lost some required
> > fields.
> 
> It's a bit funny to be talking about all this, when the purpose of
> this
> patch in this series is to make it so that the shader_info can be
> ralloced.  Maybe mention that?

Added and pushed. Thanks for the review and sorry again for breaking
things :)

> 
> The series as a whole should get things working again, though, so I'd
> like to see it land.  Reviewed-by: Eric Anholt <eric at anholt.net>
> 
> (I was actually in the middle of testing a workaround based on
> calling
> nir_gather_info, because I needed vc4 fixed).

I did post a part 1 of the shader_info refactor that should have also
fixed this but Jason wanted to see the whole thing which was going to
take a bit more time.

I'd be happy to review the nir_gather_info() patches as Jason is still
keen to head in this direction.

I had a patch to call gather info in progress also:

https://github.com/tarceri/Mesa/commit/fe0c5bfdc5d866feec83636766a3c8ad
e41d85fe

> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev