[Mesa-dev] [PATCH 3/4] gallium/radeon: Use flags parameter in radeon_winsys_surface_init

[Dieter Nützel]

Am 02.11.2016 12:11, schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> Fixes valgrind warnings about surf_ws->flags being uninitialized while
> starting X.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
>  src/gallium/winsys/radeon/drm/radeon_drm_surface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_surface.c
> b/src/gallium/winsys/radeon/drm/radeon_drm_surface.c
> index 7b85973..6836a1b 100644
> --- a/src/gallium/winsys/radeon/drm/radeon_drm_surface.c
> +++ b/src/gallium/winsys/radeon/drm/radeon_drm_surface.c
> @@ -228,7 +228,7 @@ static int radeon_winsys_surface_init(struct
> radeon_winsys *rws,
> 
>      surf_winsys_to_drm(&surf_drm, tex, flags, bpe, mode, surf_ws);
> 
> -    if (!(surf_ws->flags & RADEON_SURF_IMPORTED)) {
> +    if (!(flags & RADEON_SURF_IMPORTED)) {
>         r = radeon_surface_best(ws->surf_man, &surf_drm);
>         if (r)
>            return r;

Changing this to:

-    if (!(surf_ws->flags & RADEON_SURF_IMPORTED)) {
+    if (!(flags & (RADEON_SURF_IMPORTED | RADEON_SURF_FMASK))) {

A combination with Marek's idea SOLVED
both (FreeCAD and LS2015 on Wine) for me.
https://bugs.freedesktop.org/show_bug.cgi?id=98518

So you have my
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>

Greetings,
Dieter