[Mesa-dev] [PATCH 2/3] glx/glvnd: Fix dispatch function names and indices

[Emil Velikov]

On 1 November 2016 at 19:06, Adam Jackson <ajax at redhat.com> wrote:
> On Mon, 2016-10-31 at 20:28 +0000, Emil Velikov wrote:
>> >
>> > One user, xdriinfo(1), which is admittedly pretty useless. But the
>> > glvnd code in mesa definitely implements dispatch for it (libglvnd
>> > itself does not, but is not expected to).
>>
>> libglvnd doesn't dispatch to it one cannot really reach it, correct ?
>
> Incorrect. Consider: there's no explicit dispatch code in libglvnd for
> GLX_EXT_texture_from_pixmap either. And yet, somehow,
> glXGetProcAddress("glXBindTexImageEXT") will return a working function
> pointer.
>
Hmm must have had a corrupted/incomplete build last time as the
generated code was missing any references of glXGetScreenDriver. Upon
closer look it is there (alongside glXGetDriverConfig and
GLX_EXT_texture_from_pixmap).
I'm not a fan of keeping legacy stuff with only one (pretty useless)
user. Not to mention that the glXGetDriverConfig plumbing is missing
[in here]. But as you feel so strongly in keeping it ...

For the series:
Cc: "12.0 13.0" <mesa-stable at lists.freedesktop.org>
Fixes: 22a9e00aab6 ("glx: Implement the libglvnd interface.")
Acked-by: Emil Velikov <emil.velikov at collabora.com>


-Emil