[Mesa-dev] [PATCH] glsl: Do not allow scalar types in vector relational functions

Matt Turner mattst88 at gmail.com
Fri Nov 4 19:23:39 UTC 2016


On Sun, Oct 30, 2016 at 11:45 PM, Boyan Ding <boyan.j.ding at gmail.com> wrote:
> According to OpenGL Shading Language 4.50 spec, Section 8.7 "Vector
> Relational Functions", functions of this type do not operate on scalar
> types, so remove scalar types from signature definitions to make the
> behavior consistent with glslangValidator and other drivers.

Yep. Looks like it's always been this way.

The patch is

Reviewed-by: Matt Turner <mattst88 at gmail.com>

Since this seems to be untested by any suite, could you provide some
piglit parser tests that confirm that lessThanEqual(scalar, scalar),
et al doesn't work?

Rant: what a stupid mess to require <= for scalars but lessThanEqual
for vectors.

Somewhere on my todo list is a GLSL extension that fixes things like this...


More information about the mesa-dev mailing list