[Mesa-dev] [PATCH 1/3] glsl: use the prefixed name of the lexer generated functions

[Emil Velikov]

On 3 November 2016 at 22:42, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> On Fri, 2016-11-04 at 08:56 +1100, Timothy Arceri wrote:
>> On Thu, 2016-10-27 at 12:41 +0100, Emil Velikov wrote:
>> >
>> > From: Emil Velikov <emil.velikov at collabora.com>
>> >
>> > Flex version 2.6.2 does not expand (define) the yy version of some
>> > function, thus we fail to compile.
>>
>> functions
>>
>> >
>> >
>> > Strictly speaking this might be a flex bug, although expanding the
>> > few
>> > instances is perfectly trivial and works with 2.6.2 and earlier
>> > versions
>> > of flex.
>>
>> This seems a bit fragile to me. As far as I can tell (although it
>> might
>> be unlikely) there is no guarantee that the expanded functions won't
>> be
>> be changed on the flex end and require renaming again in future.
>>
>> It would be nice if we could discover the real problem rather than
>> papering over it.
>
> This looks like it:
>
> https://github.com/westes/flex/issues/113
>
> I've added it to the bug report. Looking at the gentoo tracker bug it
> looks like this breaks a bunch of software not just Mesa. I think we
> should probably just wait and see what happens there before changing
> anything.
>
Fine with me. Btw, I did double check that older flex does work like a charm.
One might get the odd (depending on GCC used) warning, but that won't
cause any issues... unless flex does some fundamental design breakage
;-)

Thanks
Emil