[Mesa-dev] [PATCH] android: amd/common: add support for libmesa_amd_common

[Emil Velikov]

On 5 November 2016 at 21:57, Marek Olšák <maraeo at gmail.com> wrote:
> On Nov 5, 2016 9:03 PM, "Mauro Rossi" <issor.oruam at gmail.com> wrote:
>>
>> 2016-11-05 18:58 GMT+01:00 Marek Olšák <maraeo at gmail.com>:
>> > Hi,
>> >
>> > I pushed the patch from the bug report. Hopefully it's the same as this
>> > one.
>> >
>> > Marek
>>
>> Hi Marek, thanks,
>> it is identical.
>>
>> As a side note, for any people trying to build mesa-dev for android,
>> a problem affecting our nougat-x86 x84_64 build  is that we
>> (android-x86 volounteers) haven't managed to properly fix llvm to
>> export prototypes of LLVMInitializeAMDGPU* functions, even if AMDGPU
>> backend was bullt.
>>
>> The problem is the same mentioned here:
>> https://lists.freedesktop.org/archives/mesa-dev/2016-March/109602.html
>> where issue seems related to missing porting of
>> ./include/llvm/Config/Target.def processing in Android makefiles in
>> llvm.
>>
>> At the moment in my personal branch I'm using the
>> -Wno-error=implicit-function-declaration LOCAL_CFLAG,
>> but it can't be upstreamed to mesa-dev
>>
>> I will need to knock at the door of llvm/aosp experts, in the
>> appropriate forums or just continue my trial and error progression.
>
> If you want to add some hacks to Mesa for Android, that's fine with me. I
> don't think we have many Android users, so some build system hacks shouldn't
> bother anyone, is that right Emil?
>
Yes and no. Yes, having the odd hack isn't an issue. On the other hand
getting it merged and 'never' fixing it, is. One piece that comes to
mind - commit c3b5afbd4e6 dated ~May 2015.

In general we want to cleanup the asymmetric/outdated Android build
that lead to stuff such as 7cb197c3a8c or the [multiple] issues due to
duplicated/out of sync sources lists/includes/generation rules.

We want to get stuff sorted, before slapping even more on top thus
making it even harder to manage. Right ?
Emil