[Mesa-dev] [PATCH 2/3] swr: disable logic op when the rt format is float

[Ilia Mirkin]

Ah indeed, I missed that. That's what I get for looking at the man page.

On Tue, Nov 8, 2016 at 12:25 PM, Rowley, Timothy O
<timothy.o.rowley at intel.com> wrote:
> Looking at the spec, that seems like that should also check for sRGB and also disable in that case (“GetFormatInfo(compileState.format).isSRGB”).
>
>> On Nov 7, 2016, at 6:18 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>> src/gallium/drivers/swr/swr_state.cpp | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp
>> index d8a8ee1..acb0452 100644
>> --- a/src/gallium/drivers/swr/swr_state.cpp
>> +++ b/src/gallium/drivers/swr/swr_state.cpp
>> @@ -1305,6 +1305,11 @@ swr_update_derived(struct pipe_context *pipe,
>>                    &ctx->blend->compileState[target],
>>                    sizeof(compileState.blendState));
>>
>> +            if (compileState.blendState.logicOpEnable &&
>> +                GetFormatInfo(compileState.format).type[0] == SWR_TYPE_FLOAT) {
>> +               compileState.blendState.logicOpEnable = false;
>> +            }
>> +
>>             if (compileState.blendState.blendEnable == false &&
>>                 compileState.blendState.logicOpEnable == false) {
>>                SwrSetBlendFunc(ctx->swrContext, target, NULL);
>> --
>> 2.7.3
>>
>