[Mesa-dev] [PATCH v4 00/10] anv: Rework relocation handling

[Jason Ekstrand]

On Wed, Nov 9, 2016 at 11:26 AM, Kristian Høgsberg <hoegsberg at gmail.com>
wrote:

> On Mon, Nov 7, 2016 at 2:27 PM Jason Ekstrand <jason at jlekstrand.net>
> wrote:
>
>> This is the fourth iteration of my attempt to rework relocation handling
>> and do relocations in userspace.  I'm finally getting pretty happy with
>> this and I think I'll probably merge this version if there are no further
>> objections.
>>
>> Jason Ekstrand (9):
>>   anv: Add a cmd_buffer_execbuf helper
>>   anv: Don't presume to know what address is in a surface relocation
>>   anv: Add a new bo_pool_init helper
>>   anv/allocator: Simplify anv_scratch_pool
>>   anv: Initialize anv_bo::offset to -1
>>   anv/batch_chain: Improve write_reloc
>>   anv: Add an anv_execbuf helper struct
>>   anv/batch: Move last_ss_pool_bo_offset to the command buffer
>>   anv: Move relocation handling from EndCommandBuffer to QueueSubmit
>>
>>
> That all looks good, happy that you were able to get this idea working. I
> would keep the execbuf bo list around in the VkCmdBuffer structure instead
> of allocating and freeing the exact same amount on each execbuf, but I know
> you like to malloc. For the series:
>

Actually, what I've thought about doing is to keep it around in the queue.
re-submitting command buffers isn't that common of a thing but if we kept
it in the queue, we'd barely ever malloc once it gets warmed up.  That's a
refactor for another day.


> Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
>

Thanks!


> Kristian Høgsberg (1):
>>   anv: Do relocations in userspace before execbuf ioctl
>>
>>  src/intel/vulkan/anv_allocator.c   | 118 +++++-------
>>  src/intel/vulkan/anv_batch_chain.c | 386 ++++++++++++++++++++++++++----
>> -------
>>  src/intel/vulkan/anv_device.c      |  49 +++--
>>  src/intel/vulkan/anv_intel.c       |  11 +-
>>  src/intel/vulkan/anv_private.h     |  43 +++--
>>  src/intel/vulkan/genX_cmd_buffer.c |  11 --
>>  6 files changed, 384 insertions(+), 234 deletions(-)
>>
>> --
>> 2.5.0.400.gff86faf
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161109/f0cc8d56/attachment.html>