[Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

Emil Velikov emil.l.velikov at gmail.com
Wed Nov 9 20:21:47 UTC 2016


On 9 November 2016 at 08:32, Tomasz Figa <tfiga at chromium.org> wrote:
> It is currently completely broken, as it ends up using RGBX_8888 on
> hardware side, due to no way of distinguishing between these two in the
> DRI API, while HAL_PIXEL_FORMAT_RGB_888 is clearly defined to be the
> 3-byte per pixel RGB format.
>
> Signed-off-by: Tomasz Figa <tfiga at chromium.org>
Nicely spotted ! I wonder if there will be any real benefit in using
the RGB_888.
If so we can extend the DRI loader/driver interface for that (and then
go and fix the drivers).

Shouldn't platform_surfaceless.c need a similar trick ?

Regardless:
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil


More information about the mesa-dev mailing list