[Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to GCC i386

Emil Velikov emil.l.velikov at gmail.com
Wed Nov 9 21:48:39 UTC 2016


On 9 November 2016 at 20:54, Rob Herring <robh at kernel.org> wrote:
> On Wed, Nov 2, 2016 at 10:42 PM, Rob Herring <robh at kernel.org> wrote:
>> On Wed, Nov 2, 2016 at 10:32 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> From: Emil Velikov <emil.velikov at collabora.com>
>>>
>>> The use of regparm causes an error on arm/arm64 builds with clang.
>>> fastcall is allowed, but still throws a warning. As both options only
>>> have effect on 32-bit x86 builds, limit them to that case.
>>>
>>> v2: keep the __i386__ within GCC (Nicolai)
>>>
>>> Cc: 13.0 <mesa-stable at lists.freedesktop.org>
>>> Cc: Rob Herring <robh at kernel.org>
>>> Cc: Nicolai Hähnle <nhaehnle at gmail.com>
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>
>> Thanks for respinning this for me.
>>
>> Reviewed-by: Rob Herring <robh at kernel.org>
>
> Any reason this hasn't been applied yet? My Android CI job is still
> failing on this.
>
Too much git checkout/reset w/o git push :-\

It's all sorted now. Thanks for the reminder !
Emil


More information about the mesa-dev mailing list