[Mesa-dev] [PATCH 01/14] swr: [rasterizer jitter] code style fix

Rowley, Timothy O timothy.o.rowley at intel.com
Thu Nov 10 03:43:07 UTC 2016


Oh, good spotting.  I had incorporated the earlier version of your patch which had the other bracing “if () {“ bracing stye.  I’ll remove this change from the push.

> On Nov 9, 2016, at 9:38 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> 
> What's the preferred style? It seems like every other if () in this
> file has a { starting on the next line. That's why I ended up doing it
> that way as well..
> 
> On Wed, Nov 9, 2016 at 10:18 PM, Tim Rowley <timothy.o.rowley at intel.com> wrote:
>> ---
>> src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp
>> index 46ea495..d69d503 100644
>> --- a/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp
>> +++ b/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp
>> @@ -652,8 +652,7 @@ struct BlendJit : public Builder
>>             Value* vMask[4];
>>             float scale[4];
>> 
>> -            if (!state.blendState.blendEnable)
>> -            {
>> +            if (!state.blendState.blendEnable) {
>>                 Clamp(state.format, src);
>>                 Clamp(state.format, dst);
>>             }
>> --
>> 2.7.4
>> 
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list