[Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

Timothy Arceri timothy.arceri at collabora.com
Thu Nov 10 08:21:40 UTC 2016


On Wed, 2016-11-09 at 23:09 -0800, Kenneth Graunke wrote:
> On Wednesday, October 26, 2016 6:30:43 PM PST Andres Gomez wrote:
> [snip]
> > 
> > The main changes in this v3 series are:
> >   Patch 2/8 has been modified to use an additional default_layout
> >     variable instead of a layout_helper and the merges are done
> >     directly on the layout one.
> >   Old patch v2 5/9 has been removed, which was allowing multiple
> >     layout-qualifiers in the same declaration with
> >     ARB_enhanced_layouts in addition to
> > ARB_shading_language_420pack.
> > 
> > Fixes:
> > - GL44-CTS.shading_language_420pack.qualifier_override_layout
> > - GL44-CTS.enhanced_layouts.xfb_duplicated_stride
> 
> What's the status of this landing?  It sounds like Timothy was pretty
> happy with it, but I'm wondering if something got lost in
> communication.

I asked that we avoid regressing the column number on error messages
for global qualifiers which required some refactoring. Otherwise it
looks good.

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list