[Mesa-dev] [PATCH v2 5/8] gallium scons: Added swr driver to scons

[Emil Velikov]

On 9 November 2016 at 23:18, George Kyriazis <george.kyriazis at intel.com> wrote:
> Enable swr builds by "scons swr=1 libgl-gdi" (windows only)
Summary is wrong/misleading. Here we add add the driver side plumbing
- one cannot build _any_ target yet. Be that libgl-gdi or any other.

> +import SCons.Script.SConscript
> +
> +if 'swr' in SCons.Script.ARGUMENTS and not SCons.Script.ARGUMENTS['swr']:
> +    Return()
> +
> +if not env['llvm']:
> +    print 'warning: LLVM disabled: not building swr'
> +    Return()
> +
Wondering if having this in the toplevel SCons files - SConstruct,
common.py or scons/* won't be a better idea.
I'll let Jose comment on it ... who seems to be missing from the CC list :-(

> +source = [
> +    'rasterizer/scripts/gen_knobs.cpp',
> +    'rasterizer/jitter/builder_gen.cpp',
> +    'rasterizer/jitter/builder_x86.cpp',
Idea for future cleanup - please move this [+ .h/.hpp] files list to
Makefile.sources and reuse them in both builds.

Thanks
Emil