[Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

[Emil Velikov]

On 10 November 2016 at 17:27, Kyriazis, George
<george.kyriazis at intel.com> wrote:
>> -----Original Message-----
>> From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
>> Sent: Thursday, November 10, 2016 8:14 AM
>> To: Kyriazis, George <george.kyriazis at intel.com>
>> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>
>> Subject: Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver
>>
>> "gallium/targets: scons: wire swr support for libgl-gdi/libgl-xlib/osmesa"
>>
>> ... or alike ?
>>
>> > +import SCons.Script.SConscript
>> > +
>>
>> > +    if 'swr' in SCons.Script.ARGUMENTS and
>> SCons.Script.ARGUMENTS['swr']:
>> With the "move this to top level" suggestion this will read roughly as
>>
>> if env['swr']:
>>
> The command line variables, however (like swr=1) are not part of the environment.  Even then, env['swr'] would fail for non-swr builds, since 'swr' is not in the env dictionary.  This works for env['llvm'] sincellvm.py initially sets it to False.  So, it will still be a 2-level test:   if 'swr' in env and env['swr']:, which is not a simplication really.
>
> Is your point to move it to the environment, or to do a one-check test?
>
To consolidate the 'clunky' SCons.Script.ARGUMENTS + requirements
[only llvm?] checking in a single place. Thus the [newly added in the
env dictionary] swr can be used throughout without even import(ing)
SCons.Script.SConscript.

Thanks !
Emil