[Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

Emil Velikov emil.l.velikov at gmail.com
Thu Nov 10 20:25:15 UTC 2016


On 27 October 2016 at 17:06, Gurchetan Singh
<gurchetansingh at chromium.org> wrote:
> In Android, the pthreads libs are in bionic.  When building
> Mesa for Android with the autotools workflow, we shouldn't
> set -lpthread or -pthread.
> ---
>  configure.ac | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4761c59..3f21cd5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -823,8 +823,11 @@ if test "x$ax_pthread_ok" = xno; then
>  fi
>  dnl AX_PTHREADS leaves PTHREAD_LIBS empty for gcc and sets PTHREAD_CFLAGS
>  dnl to -pthread, which causes problems if we need -lpthread to appear in
> -dnl pkgconfig files.
> -test -z "$PTHREAD_LIBS" && PTHREAD_LIBS="-lpthread"
> +dnl pkgconfig files.  Since Android doesn't have a pthread lib, this check
> +dnl is not valid for that platform.
> +if test "x$android" = xno; then
> +    test -z "$PTHREAD_LIBS" && PTHREAD_LIBS="-lpthread"
> +fi
>
This and 2/2 v3 are
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks for the patience and updates !
-Emil


More information about the mesa-dev mailing list