[Mesa-dev] [PATCH 1/2] anv/descriptor_set: Write the state offset in the surface state free list.

Iago Toral itoral at igalia.com
Mon Nov 14 16:09:37 UTC 2016


On Thu, 2016-11-10 at 16:53 -0800, Jason Ekstrand wrote:
> When Kristian reworked descriptor set allocation, somehow he forgot
> to
> actually store the offset in the free list.  Somehow, this completely
> missed CTS testing until now... This fixes all 2744 of the new
> 'dEQP-VK.texture.filtering.* tests in the latest CTS.
> 
> Cc: "12.0 13.0" <mesa-dev at lists.freedesktop.org>
> ---
>  src/intel/vulkan/anv_descriptor_set.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/intel/vulkan/anv_descriptor_set.c
> b/src/intel/vulkan/anv_descriptor_set.c
> index 7d5a78d..52f2df6 100644
> --- a/src/intel/vulkan/anv_descriptor_set.c
> +++ b/src/intel/vulkan/anv_descriptor_set.c
> @@ -489,6 +489,7 @@ anv_descriptor_set_destroy(struct anv_device
> *device,
>        struct surface_state_free_list_entry *entry =
>           set->buffer_views[b].surface_state.map;
>        entry->next = pool->surface_state_free_list;
> +      entry->offset = set->buffer_views[b].surface_state;

This will fail to compile, I think you meant:

entry->offset = set->buffer_views[b].surface_state.offset;

With that change, both patches are:
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

>        pool->surface_state_free_list = entry;
>     }
>  


More information about the mesa-dev mailing list