[Mesa-dev] [PATCH] anv: fix multi level clears with VK_REMAINING_MIP_LEVELS

[Nanley Chery]

On Mon, Nov 14, 2016 at 05:26:09PM +0000, Lionel Landwerlin wrote:
> A commit from the CTS suite on the 1.0-dev branch started using
> VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears.
> 
> Fixes:
>    dEQP-VK.api.image_clearing.clear_color_image.*
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/intel/vulkan/anv_blorp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch is
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>

> 
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index b78c21d..d59c1a7 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -803,7 +803,7 @@ void anv_CmdClearColorImage(
>        unsigned base_layer = pRanges[r].baseArrayLayer;
>        unsigned layer_count = pRanges[r].layerCount;
>  
> -      for (unsigned i = 0; i < pRanges[r].levelCount; i++) {
> +      for (unsigned i = 0; i < anv_get_levelCount(image, &pRanges[r]); i++) {
>           const unsigned level = pRanges[r].baseMipLevel + i;
>           const unsigned level_width = anv_minify(image->extent.width, level);
>           const unsigned level_height = anv_minify(image->extent.height, level);
> @@ -863,7 +863,7 @@ void anv_CmdClearDepthStencilImage(
>        unsigned base_layer = pRanges[r].baseArrayLayer;
>        unsigned layer_count = pRanges[r].layerCount;
>  
> -      for (unsigned i = 0; i < pRanges[r].levelCount; i++) {
> +      for (unsigned i = 0; i < anv_get_levelCount(image, &pRanges[r]); i++) {
>           const unsigned level = pRanges[r].baseMipLevel + i;
>           const unsigned level_width = anv_minify(image->extent.width, level);
>           const unsigned level_height = anv_minify(image->extent.height, level);
> -- 
> 2.10.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev