[Mesa-dev] [PATCH 0/7] GLSL: Lowering small conditional branches

Nicolai Hähnle nhaehnle at gmail.com
Tue Nov 15 09:48:35 UTC 2016


On 12.11.2016 20:34, Marek Olšák wrote:
> On Wed, Nov 2, 2016 at 10:33 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> On Wed, Nov 2, 2016 at 3:02 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>>> Patches 1, 2, 4 - 6:
>>>
>>> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> Thanks.
>>
>>>
>>> I have one pending LLVM patch related to indirect addressing. Not sure if
>>> that's related to the regressions, but it may be.
>>
>> LLVM master fixes all but one regression. It's:
>>
>> spec at glsl-1.10@execution at variable-indexing@vs-output-array-vec3-index-wr
>
> Nicolai, is that regression OK with you? The decrease in spilling is
> worth it. There is no CTS regression. Can I get Rbs for patches 3 & 7?

Yes, I understand the point of patch #3 now, and as for the regression, 
it might actually be similar to another problem I'm looking at right 
now. You can add my R-b for 3 & 7 as well.

Nicolai

>
> Thanks,
> Marek
>


More information about the mesa-dev mailing list