[Mesa-dev] [PATCH v2 1/3] loader: add loader_get_extensions_name(..) helper

[Emil Velikov]

On 12 November 2016 at 16:26, Christian Gmeiner
<christian.gmeiner at gmail.com> wrote:

> ../../include/GL/internal/dri_interface.h:512:5: error: unknown type
> name 'GLboolean'
>      GLboolean front_buffer,
>      ^~~~~~~~~
> ../../include/GL/internal/dri_interface.h:514:1: warning: no semicolon
> at end of struct or union
>  };
>  ^
> ../../include/GL/internal/dri_interface.h:1288:4: error: expected
> specifier-qualifier-list before 'GLboolean'
>     GLboolean (*queryImage)(__DRIimage *image, int attrib, int *value);
>     ^~~~~~~~~
> Makefile:641: recipe for target 'libloader_la-loader.lo' failed
> make[3]: *** [libloader_la-loader.lo] Error 1
> make[3]: Leaving directory '/run/media/christian/christian/ac_mesa/src/loader'
> Makefile:865: recipe for target 'all-recursive' failed
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory '/run/media/christian/christian/ac_mesa/src'
> Makefile:656: recipe for target 'all' failed
> make[1]: *** [all] Error 2
>
Grr, I forgot that dri_interface.h is using GL types yet does not
include any header that provides them.

>> Let me know how you feel on the latter and I can amend accordingly
>> before pushing.
>
> The only way to life without those includes would be move
> __DRI_DRIVER_GET_EXTENSIONS define
> but that feels quite strange.
>
Yes having a local define is what I had in mind. Apologies, I should
have made it clearer.

With the fun that we've been having with GL and mesa_interop headers,
typedefs and alike, I've "tweaked" the patch to use a local define and
landed the series.
Not too happy about it, but it's a minor hack that will save us a fair
few others.

Thanks
Emil