[Mesa-dev] [PATCH] ac/nir/llvm: fix channel in texture gather lowering code.

[Dave Airlie]

On 15 November 2016 at 17:33, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Just noticed this by inspection, while trying to locate other
> CTS failures. Don't think it fixes anything, but it might be
> needed once I find the proper fix.

Just noticed it does fix some CTS tests fails like
dEQP-VK.glsl.texture_gather.basic.2d.rgba8i.size_npot.repeat_mirrored_repeat

so I'll push it later.

Dave.

> ---
>  src/amd/common/ac_nir_to_llvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index cb0d9a6..5887125 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -1764,7 +1764,7 @@ static LLVMValueRef radv_lower_gather4_integer(struct nir_to_llvm_context *ctx,
>
>                 for (c = 0; c < 2; c++) {
>                         half_texel[c] = LLVMBuildExtractElement(ctx->builder, size,
> -                                                               ctx->i32zero, "");
> +                                                               LLVMConstInt(ctx->i32, c, false), "");
>                         half_texel[c] = LLVMBuildUIToFP(ctx->builder, half_texel[c], ctx->f32, "");
>                         half_texel[c] = emit_fdiv(ctx, ctx->f32one, half_texel[c]);
>                         half_texel[c] = LLVMBuildFMul(ctx->builder, half_texel[c],
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev