[Mesa-dev] [PATCH] android: amd/common: add support for libmesa_amd_common

[Emil Velikov]

On 15 November 2016 at 09:15, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 12.11.2016 22:26, Mauro Rossi wrote:
>>>
>>> We'd really want to do:
>>>
>>> git rm src/amd/common/Makefile.sources
>>> git mv src/amd/common/Makefile.am src/amd/Makefile.common.am
>>> sed -i s|common/||g src/amd/Makefile.common.am
>>> + fix the odd piece throughout.
>>>
>>> As-is we have the sources lists duplicated and makefiles async from
>>> one another. And if history has thought us anything - this will break
>>> all the everytime.
>>>
>>> Mauro, can you give it a try ?
>>>
>>> Thanks
>>> Emil
>>
>>
>> Hi,
>>
>> sed command was not necessary but I had to add
>> $(top_src)/src/amd/common include,
>> change configure.ac (like Jason Ekstrand had to do when isl makefile
>> structure was flattened),
>> modify Makefile.common.am as Makefile.addrlib.am
>>
>> I've tried to build and there is no amd related error, it should be ok,
>> but in my "mesa for linux" build system I am lacking proper llvm
>> installation and I see llvm building errors, probably related to this
>> fact.
>>
>> Please review and check by launching a build on your more stable linux
>> build systems/CI jobs, before pushing to mesa-dev
>> Thanks
>>
>> Mauro
>>
>> From f78f66049118db3ed9b241dfd020418efe52c10b Mon Sep 17 00:00:00 2001
>> From: Mauro Rossi <issor.oruam at gmail.com>
>> Date: Sat, 12 Nov 2016 22:10:44 +0100
>> Subject: [PATCH] amd: flatten amd/common makefile structure
>>
>> This pulls amd/common build rules into upper level makefile,
>> along with amd/addlib which is already there.
>
>
> Looks reasonable to me, but perhaps somebody with more familiarity with the
> build system can take another look?
>
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
I've unintentionally missed out your r-b Nicolai, apologies.

Had to apply a couple of small fixes, other than that it looks great.

Thank you Mauro!
Emil