[Mesa-dev] [PATCH 1/7] intel: Convert devinfo->urb.max_*_entries into an array.

[Kenneth Graunke]

On Wednesday, November 16, 2016 10:56:32 AM PST Pohjolainen, Topi wrote:
> On Tue, Nov 15, 2016 at 05:53:56PM -0800, Kenneth Graunke wrote:
> > diff --git a/src/intel/common/gen_device_info.h b/src/intel/common/gen_device_info.h
> > index 10324e6..3125a68 100644
> > --- a/src/intel/common/gen_device_info.h
> > +++ b/src/intel/common/gen_device_info.h
> > @@ -135,12 +135,14 @@ struct gen_device_info
> >         * urb.size = URB Size (kbytes) / slice count
> >         */
> >        unsigned size;
> > +
> >        unsigned min_vs_entries;
> > -      unsigned max_vs_entries;
> > -      unsigned max_tcs_entries;
> >        unsigned min_ds_entries;
> > -      unsigned max_tes_entries;
> > -      unsigned max_gs_entries;
> > +
> > +      /**
> > +       * The maximum number of URB entries.  See the 3DSTATE_URB_<XS> docs.
> > +       */
> > +      unsigned max_entries[4];
> 
> I had to go and check "shader_enums.h" if all MESA_SHADER_* values here
> actually fit. And they do. I'm still wondering if we should try to tie the
> size somehow to the enums. Perhaps "max_entries[MESA_SHADER_GEOMETRY + 1]",
> what do you think?

That's a good idea.

I'd originally written it as max_entries[MESA_SHADER_FRAGMENT], but I
didn't really like that, as fragment shaders aren't part of the URB,
and it looked weird.  GEOMETRY + 1 makes sense though.

I suppose I have a lot of [4] to change in the last two patches
though...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161116/ce1108f7/attachment-0001.sig>