[Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

[Varad Gautam]

On Wed, Nov 16, 2016 at 12:25 PM, Michel Dänzer <michel at daenzer.net> wrote:
> On 15/11/16 11:24 PM, Varad Gautam wrote:
>> From: Varad Gautam <varad.gautam at collabora.com>
>>
>> drivers should implement pipe_screen->get_modifiers_for_format and
>> advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to support format
>> modifier queries.
>
> Is there any point in having the PIPE_CAP_QUERY_DMABUF_MODIFIERS cap, vs
> just testing if pipe_screen->get_modifiers_for_format != NULL ?

The PIPE_CAP is to convey that the driver supports modifier queries as
compatible with the egl ext (64b), as compared to drivers that wish to treat
modifiers differently. If this isn't a concern, I can replace it with the NULL
check.

Thanks,
Varad

>
>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer