[Mesa-dev] [PATCH 08/12] docs/submittingpatches: fix tags mis/abuse
Emil Velikov
emil.l.velikov at gmail.com
Wed Nov 16 18:46:20 UTC 2016
From: Emil Velikov <emil.velikov at collabora.com>
Fix the odd tag so that we're HTML 4.01 Traditional compliant
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
docs/submittingpatches.html | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index 07777ab..9af1cb7 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
@@ -134,7 +134,7 @@ to check for regressions.
<p>
Patches should be sent to the mesa-dev mailing list for review:
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">
-mesa-dev at lists.freedesktop.org<a/>.
+mesa-dev at lists.freedesktop.org</a>.
When submitting a patch make sure to use
<a href="https://git-scm.com/docs/git-send-email">git send-email</a>
rather than attaching patches to emails. Sending patches as
@@ -161,6 +161,7 @@ state of your old patches to Superseded.
<p>
When you've reviewed a patch on the mailing list, please be unambiguous
about your review. That is, state either
+</p>
<pre>
Reviewed-by: Joe Hacker <jhacker at foo.com>
</pre>
@@ -168,14 +169,17 @@ or
<pre>
Acked-by: Joe Hacker <jhacker at foo.com>
</pre>
+<p>
Rather than saying just "LGTM" or "Seems OK".
</p>
<p>
If small changes are suggested, it's OK to say something like:
+</p>
<pre>
With the above fixes, Reviewed-by: Joe Hacker <jhacker at foo.com>
</pre>
+<p>
which tells the patch author that the patch can be committed, as long
as the issues are resolved first.
</p>
--
2.9.3
More information about the mesa-dev
mailing list