[Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

[Emil Velikov]

On 16 November 2016 at 02:27, George Kyriazis <george.kyriazis at intel.com> wrote:
> Modify gen_knobs.py so that each invocation creates a single generated
> file.  This is more similar to how the other generators behave.
Nicely done.

>  mode change 100644 => 100755 src/gallium/drivers/swr/Makefile.am
Please don't !

>
>  env.CodeGenerate(
> -    target = 'rasterizer/archrast/gen_ar.event.cpp',
> +    target = 'rasterizer/archrast/gen_ar_event.cpp',
>      script = swrroot + 'rasterizer/scripts/gen_archrast.py',
>      source = 'rasterizer/archrast/events.proto',
> -    command = python_cmd + ' $SCRIPT --proto $SOURCE --output $TARGET --gen-event_cpp'
> +    command = python_cmd + ' $SCRIPT --proto $SOURCE --output $TARGET --gen_event_cpp'
Squash there with 8/10


>
> -source = [
> +# Auto-generated .cpp files (that need to generate object files)
> +built_sources = [
>      'rasterizer/scripts/gen_knobs.cpp',
>      'rasterizer/jitter/builder_gen.cpp',
>      'rasterizer/jitter/builder_x86.cpp',
> +    'rasterizer/archrast/gen_ar_event.cpp',
>      ]
>
> +source = built_sources
and these.

With that
1-5 and 7-9 (with the bits squashed appropriately) are
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

6/10 and the potential 5.5/10 need some work.

This one is
Acked-by: Emil Velikov <emil.velikov at collabora.com>

Emil