[Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

[Emil Velikov]

On 17 November 2016 at 11:29, Vedran Miletić <vedran at miletic.net> wrote:
> On 11/16/2016 11:21 PM, Vinson Lee wrote:
>> On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
>>> On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote:
>>>> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM
>>>> 3.9 and older versionsin  Clover. This patch restores it and refactors
>>>> the support using Clover compatibility layer for LLVM.
>>>>
>>>> Signed-off-by: Vedran Miletić <vedran at miletic.net>
>>>
>>> LGTM.
>>> Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>
>>>
>>> Jan
>>>
>>
>> With this patch, I get this build error with llvm-3.8.
>>
>> In file included from llvm/codegen/bitcode.cpp:35:
>> ./llvm/compat.hpp:42:10: fatal error: 'llvm/Support/Error.h' file not found
>> #include <llvm/Support/Error.h>
>>          ^
>>
>
> Thanks for testing. Will post an updated patch soon.
>
Admittedly not a huge C++ expert, but what's wrong with having a
simple 5 line patch that adds the original code in a if guard ?
If then the LLVM <= 3.9 codepath is (somewhat) wrong, let's tackle
that separately.

Thanks
Emil