[Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

Emil Velikov emil.l.velikov at gmail.com
Fri Nov 18 11:24:08 UTC 2016


On 18 November 2016 at 04:27, George Kyriazis <george.kyriazis at intel.com> wrote:
> Also, modify gen_knobs.py so that each invocation creates a single generated
> file.  This is more similar to how the other generators behave.
> ---
>  src/gallium/SConscript                             |   1 +
>  src/gallium/drivers/swr/Makefile.am                |  15 +-
>  src/gallium/drivers/swr/SConscript                 | 216 +++++++++++++++++++++
>  .../drivers/swr/rasterizer/scripts/gen_knobs.py    |  51 ++---
>  4 files changed, 257 insertions(+), 26 deletions(-)
>  create mode 100644 src/gallium/drivers/swr/SConscript
>
This is getting tiresome :'-(

I've mentioned on multiple occasions to keep separate logical changes
into individual patches.
In my previous sounds I've _explicitly_ left only the ones (SConscript
fixes) that should be squashed here.
Please read review comments more carefully ?

When sending version X of patch series, adding r-b/ack-b/t-b/other
tags (where applicable) and brief version history is highly
recommended.
If in doubt on the latter - skim through git log + grep v2.

Thanks
Emil


More information about the mesa-dev mailing list