[Mesa-dev] [PATCH v2] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

[Daniel Stone]

Hi Emil,

On 18 November 2016 at 15:24, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 18 November 2016 at 15:17, Daniel Stone <daniel at fooishbar.org> wrote:
>> Actually, present-and-zero modifier has a very well-defined meaning:
>> it _forces_ linear interpretation of the buffer, whereas a non-present
>> modifier may cause a kernel query (e.g. i915_gem_get_tiling) to
>> discover a hidden tiling mode. So, if present, the modifier should be
>> passed.
>>
> You are suggesting that we should track "has_modifier" (as opposed to
> nonzero_modifier_found) and pass it to DmaBuf2 regardless of the
> contents, right ?

Yep, exactly that.

Cheers,
Daniel