[Mesa-dev] [Bug 98774] glsl/tests/warnings-test regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98774

            Bug ID: 98774
           Summary: glsl/tests/warnings-test regression
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: All
            Status: NEW
          Keywords: bisected, have-backtrace, regression
          Severity: normal
          Priority: medium
         Component: Mesa core
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: vlee at freedesktop.org
        QA Contact: mesa-dev at lists.freedesktop.org
                CC: emil.l.velikov at gmail.com, t_arceri at yahoo.com.au

$ make check
[...]
PASS: glsl/glcpp/tests/glcpp-test
PASS: glsl/glcpp/tests/glcpp-test-cr-lf
PASS: glsl/tests/blob-test
PASS: glsl/tests/cache-test
PASS: glsl/tests/general-ir-test
PASS: glsl/tests/optimization-test
PASS: glsl/tests/sampler-types-test
PASS: glsl/tests/uniform-initializer-test
FAIL: glsl/tests/warnings-test
PASS: nir/tests/control_flow_tests
============================================================================
Testsuite summary for Mesa 13.1.0-devel
============================================================================
# TOTAL: 10
# PASS:  9
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

$ ./glsl_compiler --just-log --version 150
./glsl/tests/warnings/000-basic-test.vert
0:8(8): warning: `undefined' used uninitialized
Segmentation fault (core dumped)

(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x000000000044a11e in link_intrastage_shaders
(mem_ctx=mem_ctx at entry=0x1391320, ctx=ctx at entry=0x717a40
<standalone_compile_shader::local_ctx>, prog=prog at entry=0x1391320,
shader_list=0x1391920, 
    num_shaders=num_shaders at entry=1,
allow_missing_main=allow_missing_main at entry=true) at glsl/linker.cpp:2196
#2  0x0000000000406c02 in standalone_compile_shader
(_options=_options at entry=0x717a10 <options>, num_files=num_files at entry=1,
files=<optimized out>) at glsl/standalone.cpp:494
#3  0x000000000040346b in main (argc=<optimized out>, argv=0x7ffe4b919888) at
glsl/main.cpp:92
(gdb) frame 1
#1  0x000000000044a11e in link_intrastage_shaders
(mem_ctx=mem_ctx at entry=0x1391320, ctx=ctx at entry=0x717a40
<standalone_compile_shader::local_ctx>, prog=prog at entry=0x1391320,
shader_list=0x1391920, 
    num_shaders=num_shaders at entry=1,
allow_missing_main=allow_missing_main at entry=true) at glsl/linker.cpp:2196
2196                                 prog->Name);
(gdb) print prog->Name
$1 = 0


9d96d3803ab5dc896d4844ac785db57bb1717f91 is the first bad commit
commit 9d96d3803ab5dc896d4844ac785db57bb1717f91
Author: Timothy Arceri <timothy.arceri at collabora.com>
Date:   Mon Oct 31 23:54:03 2016 +1100

    glsl: create gl_program at the start of linking rather than the end

    This will allow us to directly store metadata we want to retain in
    gl_program this metadata is currently stored in gl_linked_shader and
    will be lost if relinking fails even though the program will remain
    in use and is still valid according to the spec.

    "If a program object that is active for any shader stage is re-linked
    unsuccessfully, the link status will be set to FALSE, but any existing
    executables and associated state will remain part of the current
    rendering state until a subsequent call to UseProgram,
    UseProgramStages, or BindProgramPipeline removes them from use."

    This change will also help avoid the double handing that happens in
    _mesa_copy_linked_program_data().

    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

:040000 040000 97d2bb36e78083ac49ae2858d9d710b755d02941
2aa728acfaf8bc58a74f6ea379023f95c42139bf M      src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161118/9e730435/attachment-0001.html>