[Mesa-dev] [PATCH] util/disk_cache: close a previously opened handle in disk_cache_put

Mun Gwan-gyeong elongbug at gmail.com
Sun Nov 20 13:59:34 UTC 2016


We're missing the close() to the matching open().

CID 1373407

Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
---
 src/util/disk_cache.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
index 4287878..5ceb3aa 100644
--- a/src/util/disk_cache.c
+++ b/src/util/disk_cache.c
@@ -612,19 +612,18 @@ disk_cache_put(struct disk_cache *cache,
 
    p_atomic_add(cache->size, size);
 
-   /* This close finally releases the flock, (now that the final dile
-    * has been renamed into place and the size has been added).
-    */
-   close(fd);
-   fd = -1;
-
  done:
    if (filename_tmp)
       ralloc_free(filename_tmp);
    if (filename)
       ralloc_free(filename);
+   /* This close finally releases the flock, (now that the final dile
+    * has been renamed into place and the size has been added).
+    */
    if (fd != -1)
       close(fd);
+   if (fd_final != -1)
+      close(fd_final);
 }
 
 void *
-- 
2.10.2



More information about the mesa-dev mailing list