[Mesa-dev] [PATCH] gallium: create a debug screen wrapper around swrast screens

Ilia Mirkin imirkin at alum.mit.edu
Sun Nov 20 16:28:50 UTC 2016


Thanks Marek.

Emil, I'd appreciate it if you could have a look as well. I believe
you were the last to touch these helpers. I'm highly confused by the
flow of things, and mainly want to ensure that we don't warp the same
screen *twice*.

Cheers,

  -ilia

On Sun, Nov 20, 2016 at 10:56 AM, Marek Olšák <maraeo at gmail.com> wrote:
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>
> Marek
>
> On Sun, Nov 20, 2016 at 3:42 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>>  src/gallium/auxiliary/target-helpers/inline_sw_helper.h | 3 +++
>>  src/gallium/auxiliary/target-helpers/sw_helper.h        | 3 +++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/target-helpers/inline_sw_helper.h b/src/gallium/auxiliary/target-helpers/inline_sw_helper.h
>> index 5bb77a5..3d9d824 100644
>> --- a/src/gallium/auxiliary/target-helpers/inline_sw_helper.h
>> +++ b/src/gallium/auxiliary/target-helpers/inline_sw_helper.h
>> @@ -55,6 +55,9 @@ sw_screen_create_named(struct sw_winsys *winsys, const char *driver)
>>        screen = swr_create_screen(winsys);
>>  #endif
>>
>> +   if (screen)
>> +      screen = debug_screen_wrap(screen);
>> +
>>     return screen;
>>  }
>>
>> diff --git a/src/gallium/auxiliary/target-helpers/sw_helper.h b/src/gallium/auxiliary/target-helpers/sw_helper.h
>> index 5e4e9f7..d1945ad 100644
>> --- a/src/gallium/auxiliary/target-helpers/sw_helper.h
>> +++ b/src/gallium/auxiliary/target-helpers/sw_helper.h
>> @@ -57,6 +57,9 @@ sw_screen_create_named(struct sw_winsys *winsys, const char *driver)
>>        screen = swr_create_screen(winsys);
>>  #endif
>>
>> +   if (screen)
>> +      screen = debug_screen_wrap(screen);
>> +
>>     return screen;
>>  }
>>
>> --
>> 2.7.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list