[Mesa-dev] [PATCH] intel: aubinator: Fix resource leak in gen_spec_load_from_path

Mun, Gwan-gyeong elongbug at gmail.com
Mon Nov 21 12:58:51 UTC 2016


Hi, Lionel Landwerlin

Thanks for reviewing. As I do not have the permission of mesa git, I
can not push it.

If you have permission for git push, can you push this patch?

Best regards,

Gwan-gyeong.

2016-11-21 20:20 GMT+09:00 Lionel Landwerlin <lionel.g.landwerlin at intel.com>:
> Thanks!
>
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
>
> On 20/11/16 07:07, Mun Gwan-gyeong wrote:
>>
>> This fixes resource leak in gen_spec_load_from_path XML_ParserCreate
>> failure path
>>
>> CID 1373564
>>
>> Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
>> ---
>>   src/intel/tools/decoder.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/intel/tools/decoder.c b/src/intel/tools/decoder.c
>> index 6bd02bf..633251a 100644
>> --- a/src/intel/tools/decoder.c
>> +++ b/src/intel/tools/decoder.c
>> @@ -539,6 +539,7 @@ gen_spec_load_from_path(const struct gen_device_info
>> *devinfo,
>>      XML_SetUserData(ctx.parser, &ctx);
>>      if (ctx.parser == NULL) {
>>         fprintf(stderr, "failed to create parser\n");
>> +      fclose(input);
>>         free(filename);
>>         return NULL;
>>      }
>
>
>



-- 
Mun, Gwan-gyeong


More information about the mesa-dev mailing list