[Mesa-dev] [PATCH v5 09/11] swr: Modify gen_knobs.{cpp|h} creation script

Kyriazis, George george.kyriazis at intel.com
Mon Nov 21 15:00:02 UTC 2016


Thank you for the reviews, Emil.

Tim will check-in the series, since he has check-in privileges.

George

> -----Original Message-----
> From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
> Sent: Saturday, November 19, 2016 4:23 PM
> To: Kyriazis, George <george.kyriazis at intel.com>
> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>
> Subject: Re: [Mesa-dev] [PATCH v5 09/11] swr: Modify gen_knobs.{cpp|h}
> creation script
> 
> Hi George,
> 
> Thanks for sorting things.. There's a pretty trivial nitpick below, but please
> don't bother addressing it.
> Things are pretty good as-is - check with Tim/others and land the series.
> 
> On 18 November 2016 at 20:38, George Kyriazis <george.kyriazis at intel.com>
> wrote:
> > Modify gen_knobs.py so that each invocation creates a single generated
> > file.  This is more similar to how the other generators behave.
> >
> > v5: remove Scoscript edits from this commit; moved to commit that
> > first adds SConscript
> >
> > Acked-by: Emil Velikov <emil.velikov at collabora.com>
> > ---
> >  src/gallium/drivers/swr/Makefile.am                | 15 ++++++-
> >  .../drivers/swr/rasterizer/scripts/gen_knobs.py    | 51 ++++++++++++------
> ----
> 
> > @@ -235,6 +245,7 @@ libswrAVX2_la_LDFLAGS = \  include
> > $(top_srcdir)/install-gallium-links.mk
> >
> >  EXTRA_DIST = \
> > +       SConscript \
> 
> IIRC I've mentioned it a couple of times - this should be part of the commit
> that introduces the file.
> 
> Emil


More information about the mesa-dev mailing list