[Mesa-dev] [PATCH 12/18] i965: Claim that SEND/math has two sources.

Matt Turner mattst88 at gmail.com
Tue Nov 22 19:59:46 UTC 2016


src1 must be a descriptor (including the information to determine that
the SEND is doing an extended math operation), but src0 can actually be
null since it serves as the source of the implicit GRF -> MRF move.
---
 src/mesa/drivers/dri/i965/brw_eu_validate.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu_validate.c b/src/mesa/drivers/dri/i965/brw_eu_validate.c
index 8c2eb99..9648f0d 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_validate.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_validate.c
@@ -96,7 +96,14 @@ num_sources_from_inst(const struct gen_device_info *devinfo,
    } else if (devinfo->gen < 6 &&
               brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SEND) {
       if (brw_inst_sfid(devinfo, inst) == BRW_SFID_MATH) {
-         math_function = brw_inst_math_msg_function(devinfo, inst);
+         /* src1 must be a descriptor (including the information to determine
+          * that the SEND is doing an extended math operation), but src0 can
+          * actually be null since it serves as the source of the implicit GRF
+          * to MRF move.
+          *
+          * If we stop using that functionality, we'll have to revisit this.
+          */
+         return 2;
       } else {
          /* Send instructions are allowed to have null sources since they use
           * the base_mrf field to specify which message register source.
-- 
2.7.3



More information about the mesa-dev mailing list