[Mesa-dev] [PATCH] util: fix missing swizzle components in the SINT <-> UINT conversion string

[Brian Paul]

Looks good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>

On Tue, Nov 22, 2016 at 2:33 PM, Charmaine Lee <charmainel at vmware.com>
wrote:

> Fixes tgsi error introduced in commit 3817a7a. The error complains missing
> swizzle component in the conversion string "UMIN TEMP[0], TEMP[0],
> IMM[0].x".
> ---
>  src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/util/u_simple_shaders.c
> b/src/gallium/auxiliary/util/u_simple_shaders.c
> index 8be31be..7342b3d 100644
> --- a/src/gallium/auxiliary/util/u_simple_shaders.c
> +++ b/src/gallium/auxiliary/util/u_simple_shaders.c
> @@ -633,14 +633,14 @@ util_make_fs_blit_msaa_color(struct pipe_context
> *pipe,
>
>        if (dtype == TGSI_RETURN_TYPE_SINT) {
>           conversion_decl = "IMM[0] UINT32 {2147483647, 0, 0, 0}\n";
> -         conversion = "UMIN TEMP[0], TEMP[0], IMM[0].x\n";
> +         conversion = "UMIN TEMP[0], TEMP[0], IMM[0].xxxx\n";
>        }
>     } else if (stype == TGSI_RETURN_TYPE_SINT) {
>        samp_type = "SINT";
>
>        if (dtype == TGSI_RETURN_TYPE_UINT) {
>           conversion_decl = "IMM[0] INT32 {0, 0, 0, 0}\n";
> -         conversion = "IMAX TEMP[0], TEMP[0], IMM[0].x\n";
> +         conversion = "IMAX TEMP[0], TEMP[0], IMM[0].xxxx\n";
>        }
>     } else {
>        assert(dtype == TGSI_RETURN_TYPE_FLOAT);
> --
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161122/b21429de/attachment.html>