[Mesa-dev] [PATCH] anv: expose depthBiasClamp, it is already set

[Ilia Mirkin]

On Tue, Nov 22, 2016 at 11:03 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> The gen7/8_cmd_buffer logic already sets the clamp, and it's piped
> through via the dynamic state.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>
> Untested. I don't think there are any VK-CTS tests about this. But reading
> the code, it all seems to have been piped through already.

I was wrong - dEQP-VK.dynamic_state.rs_state.depth_bias_clamp - it
passes. Not exactly a thorough test of the functionality, but it's not
an easy one to do.

>
>  src/intel/vulkan/anv_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 6ad5316..9909107 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -414,7 +414,7 @@ void anv_GetPhysicalDeviceFeatures(
>        .multiDrawIndirect                        = false,
>        .drawIndirectFirstInstance                = false,
>        .depthClamp                               = true,
> -      .depthBiasClamp                           = false,
> +      .depthBiasClamp                           = true,
>        .fillModeNonSolid                         = true,
>        .depthBounds                              = false,
>        .wideLines                                = true,
> --
> 2.7.3
>